Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furo: Add breadcrumb menu #361

Closed
javabster opened this issue Jun 6, 2023 · 6 comments
Closed

Furo: Add breadcrumb menu #361

javabster opened this issue Jun 6, 2023 · 6 comments

Comments

@javabster
Copy link
Collaborator

In the existing qiskit.org/documentation pages we have a breadcrumb menu at the top of the page, which I think would be a good addition to the Furo theme. I personally find this very useful for navigation, checking file/import paths etc. , especially when I'm searching in the depths of the API reference

Screenshot 2023-06-06 at 3 57 49 PM
@javabster javabster added this to the Furo milestone Jun 6, 2023
@Eric-Arellano
Copy link
Collaborator

I'm seeing if we can contribute this to upstream Furo: pradyunsg/furo#139 (reply in thread). Abby and I are thinking that proposed design meets Qiskit brand requirements - it's similar to IBM Cloud's docs:

screenshot_2023-06-06_at_4 19 01_pm_720

@Eric-Arellano
Copy link
Collaborator

We decided with the design team (Russell, Jules, Randy, and Eddy) that breadcrumbs are a valuable feature. But it's not a blocker for Furo 1.0, including because the Furo left sidebar design already makes clear to the user where you are. This feature will be added post-Furo 1.0.

@Eric-Arellano Eric-Arellano removed this from the Furo 1.0 milestone Jun 22, 2023
@Eric-Arellano Eric-Arellano changed the title Qiskit-ify Furo Theme: Add breadcrumb menu Furo: Add breadcrumb menu Jul 3, 2023
@coruscating
Copy link
Collaborator

Also, note that Experiments was using breadcrumbs for displaying the package version no matter which page you're on (from #266):

image

By default, the only place where versions are shown is the title of the page, but most users won't notice that. I thought a good solution before breadcrumbs return would be to add a link to the home page to the sidebar that contains the package name + version, but the sidebar renders variables literally:

image

We can override the sidebar but I'd rather not do something so hacky, so other ideas are welcome.

@Eric-Arellano
Copy link
Collaborator

@coruscating I think the best fix will be #483 from the Ecosystem theme. The text will include the project version number. It will always be present in the left side bar.

@coruscating
Copy link
Collaborator

@Eric-Arellano Yeah, I didn't realize the project name will also have the version. We're good then. Maybe it'll be good to discuss whether it's the version or release number that should be there (like 0.6 versus 0.6.2).

github-merge-queue bot pushed a commit to qiskit-community/qiskit-experiments that referenced this issue Jul 19, 2023
### Summary

This PR switches the docs to the new Furo ecosystem theme.


![image](https://github.com/Qiskit-Extensions/qiskit-experiments/assets/3870315/e93ee925-805e-466a-991a-fd30b663a24f)

### Details and comments

New build variables have been added:
- `FULL_TOCTREE` builds the full API toctree when turned on. By default,
this is off for a fast build time and small file sizes. This is turned
on for deployments. See
Qiskit/qiskit_sphinx_theme#328 for more info.
- `VERSION_STRING` and `RELEASE_STRING` are exposed so that the site can
display an alternative version/release for builds. This is relevant for
the dev site, where we would like to see the `git describe` commit
string instead of the version to be clearer to users. The new theme
currently does not expose the version/release (except for the release in
the page title) since it doesn't have breadcrumbs, but this will be
added after Qiskit/qiskit_sphinx_theme#361.

### Current known issues:

The experiment gallery doesn't render correctly:


![image](https://github.com/Qiskit-Extensions/qiskit-experiments/assets/3870315/13bd6dfc-8732-4337-9e9b-67ce709f7409)
@Eric-Arellano
Copy link
Collaborator

Given that Furo makes visually clear via its left sidebar where you are—and the Qiskit Ecosystem theme shows in the top left corner the current docs version—I don't think there's much urgency to adding breadcrumbs.

It's definitely a nice to have! But I'll have much less time to work on this repo, so I'm trying to prioritize what work can realistically be done in Q3.

If anyone is interested in this feature, I'd still love to see it. The best approach is to add it to Furo directly, which Pradyun has said they'd like: pradyunsg/furo#139 (reply in thread)

@Eric-Arellano Eric-Arellano closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants