Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing stubs for universal functions #1010

Merged
merged 87 commits into from
Jan 19, 2024

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Oct 19, 2023

Closes #832
Follow up of #963 and #967

This adds the stubs for all the universal functions. After this is merged, the typing for the existing methods would be complete

note: this contains the diffs of the other PR
IvanIsCoding/rustworkx@new_graph_digraph_methods...IvanIsCoding:rustworkx:all-types-together

@IvanIsCoding IvanIsCoding added this to the 0.14.0 milestone Oct 19, 2023
@IvanIsCoding IvanIsCoding changed the title All types together Add typing stubs for universal functions Oct 19, 2023
@coveralls
Copy link

coveralls commented Oct 19, 2023

Pull Request Test Coverage Report for Build 7578610886

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 95.923%

Totals Coverage Status
Change from base Build 7572561830: -0.04%
Covered Lines: 16024
Relevant Lines: 16705

💛 - Coveralls

@RomainBrault
Copy link

Very useful PR. Any chance this will be merge soon? Thanks for your work.

@IvanIsCoding
Copy link
Collaborator Author

Very useful PR. Any chance this will be merge soon? Thanks for your work.

It will come out with the 0.14 release but I can't promise a date yet

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a couple of small questions inline

rustworkx/__init__.pyi Outdated Show resolved Hide resolved
rustworkx/__init__.pyi Outdated Show resolved Hide resolved
rustworkx/__init__.pyi Outdated Show resolved Hide resolved
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick update

@mtreinish mtreinish merged commit 27c88f6 into Qiskit:main Jan 19, 2024
25 checks passed
@IvanIsCoding IvanIsCoding deleted the all-types-together branch January 28, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyGraph not typed correctly in VSCode, disallowing autocomplete
4 participants