Upgrade PyO3 and rust-numpy to 0.21.x and Bound API #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates rustworkx to the latest release 0.21.0 and updates the API usage for the new Bound api. [1] Luckily in rustworkx the usage of py references was minimal so the migration effort wasn't too complex, it's mostly the iterators.rs module's custom traits that needed to updated to handle the new API. Fixes Qiskit#1150 [1] https://pyo3.rs/v0.21.0/migration#from-020-to-021
Pull Request Test Coverage Report for Build 8523368212Details
💛 - Coveralls |
kevinhartman
reviewed
Apr 1, 2024
mtreinish
changed the title
IvanIsCoding
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates rustworkx to the latest release 0.21.x and updates the API usage for the new Bound api. [1] Luckily in rustworkx the usage of py references was minimal so the migration effort wasn't too complex, it's mostly the iterators.rs module's custom traits that needed to updated to handle the new API.
Fixes #1150
[1] https://pyo3.rs/v0.21.0/migration#from-020-to-021