Use unsigned_abs() in max_weight_matching #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upcoming Rust 1.61.0 release a new clipply lint warning is being added to cargo clippy. This will be matched on any output from .abs() calls that immediately cast to an unsigned type [1]. This was being done in the max weight matching function in retworkx and will cause errors when 1.61.0 is released. To address this issue from coming up this commit switches the use of .abs() to .unsigned_abs(). [1] https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned
|
Oh, I guess it wasn't stabilized in 1.48 I'm just going to close this. We'll just have to disable the clippy rule after 1.61 is released I guess since we can't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming Rust 1.61.0 release a new clipply lint warning is being
added to cargo clippy. This will be matched on any output from .abs()
calls that immediately cast to an unsigned type [1]. This was being done
in the max weight matching function in retworkx and will cause errors
when 1.61.0 is released. To address this issue from coming up this
commit switches the use of .abs() to .unsigned_abs().
[1] https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned