Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyO3 to 0.17.2 #702

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Update PyO3 to 0.17.2 #702

merged 4 commits into from
Oct 19, 2022

Conversation

IvanIsCoding
Copy link
Collaborator

Bumps PyO3 and NumPy to 0.17.2

It has been a while since dependabot has sent us updates notifications for PyO3 and we missed a couple. But I think bumping to 0.17.2 should work fine given the Rust MSRV is still the same and we have released 0.12

@coveralls
Copy link

coveralls commented Oct 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3274874854

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 96.942%
Files with Coverage Reduction New Missed Lines %
src/iterators.rs 18 84.54%
Totals Coverage Status
Change from base Build 3230829263: -0.1%
Covered Lines: 13471
Relevant Lines: 13896
💛 - Coveralls

mtreinish
mtreinish approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had a branch doing this for 0.17.0 but was blocked on some breaking changes. It's good to see that 0.17.2 fixed those.

We should test to see if #696 is fixed by this or if we can fix it now that we're on the newer version. If so we can backport this for 0.12.1

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Oct 19, 2022
@mergify mergify bot merged commit c073a21 into Qiskit:main Oct 19, 2022
@IvanIsCoding
Copy link
Collaborator Author

LGTM, I had a branch doing this for 0.17.0 but was blocked on some breaking changes. It's good to see that 0.17.2 fixed those.

We should test to see if #696 is fixed by this or if we can fix it now that we're on the newer version. If so we can backport this for 0.12.1

I think I can write the tests covering the use case and make a PR by end of the week. Hopefully they pass straight away

@IvanIsCoding IvanIsCoding deleted the update_pyo3 branch October 19, 2022 19:44
@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Nov 8, 2022
mergify bot pushed a commit that referenced this pull request Nov 8, 2022
@IvanIsCoding @mergify
Update PyO3 to 0.17.2 (#702)
100b1b9 
* Update pyo3

* Clippy + Cargo fmt

* Add clippy warning that was removed

(cherry picked from commit c073a21)
@mergify mergify bot mentioned this pull request Nov 8, 2022
Merged
mergify bot added a commit that referenced this pull request Nov 9, 2022
@mergify @IvanIsCoding
Update PyO3 to 0.17.2 (#702) (#734)
d24c438 
* Update pyo3

* Clippy + Cargo fmt

* Add clippy warning that was removed

(cherry picked from commit c073a21)

Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanIsCoding @coveralls @mtreinish