Fix clippy error with new Rust 1.65 release #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.65 was recently released which added some new clippy rules. This commit fixes the failure reported when running clippy with 1.65. This would have caused a CI failure as we start using the new rust version in CI.
mtreinish
added
the
stable-backport-potential
IvanIsCoding
approved these changes
Nov 3, 2022
Pull Request Test Coverage Report for Build 3389061842
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
Rust 1.65 was recently released which added some new clippy rules. This commit fixes the failure reported when running clippy with 1.65. This would have caused a CI failure as we start using the new rust version in CI. (cherry picked from commit 9ce8d4d)
mergify bot
added a commit
that referenced
this pull request
Nov 4, 2022
* Fix clippy error with new Rust 1.65 release (#725) Rust 1.65 was recently released which added some new clippy rules. This commit fixes the failure reported when running clippy with 1.65. This would have caused a CI failure as we start using the new rust version in CI. (cherry picked from commit 9ce8d4d) * Switch from Python 3.11rc to official release (#714) * Switch from Python 3.11rc to official release * Move extras to root testenv (cherry picked from commit cd1934d) Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com> Co-authored-by: Ivan Carvalho <ivancarv@student.ubc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.65 was recently released which added some new clippy rules. This commit fixes the failure reported when running clippy with 1.65. This would have caused a CI failure as we start using the new rust version in CI.