Fix all deprecation warnings in Rust and Upload actions #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4379252718
💛 - Coveralls |
IvanIsCoding
changed the title
|
This is failing until #820 is merged (as any PR, really) but should be good to go |
1 task
mtreinish
reviewed
Feb 21, 2023
| @@ -77,12 +75,10 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| architecture: ${{ matrix.platform.python-architecture }} | |||
| - name: Install Rust toolchain | |||
| uses: actions-rs/toolchain@v1 | |||
| uses: dtolnay/rust-toolchain@master | |||
There was a problem hiding this comment.
Why is this master while other jobs use stable below?
There was a problem hiding this comment.
So, this Github action is a little bit funny because you can specify the version in the @. @stable installs Rust stable, @1.57.1 installs 1.57.1 etc. But if you want to have the version as an input (like from the matrix we have), the author suggests using the toolchain field: https://github.com/dtolnay/rust-toolchain#inputs
mtreinish
approved these changes
Mar 9, 2023
|
#401 added a new step using the old Github action so I need to update that |
mtreinish
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #719
We switch the Github Actions to install Rust as
actions-rs/toolchainis unmaintained (actions-rs/toolchain#221)We also bump
upload-artifacttov3, fixing all the remaining warnings