Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Misra-Gries edge coloring method #902
Add Misra-Gries edge coloring method #902
Changes from 10 commits
1b75a7a
5d03bd1
6dc2ee4
8afeeeb
3622dc8
fa304f5
8910881
80f1e87
1b58301
30ab378
0ab9692
1be4bd3
e29e1ea
c14df12
7659a7f
54cb3d1
39cdca9
0a8ce0c
95e5568
79a0a3e
6034b2c
f647062
0ec75ad
6cabf18
78a728c
e00226f
e5431cc
ee68b3a
dce9f1f
8d8b917
113cb27
876aab2
a10087a
4e22ad7
50398fd
7900916
7e6470d
b7ba595
a3928ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for fun you could do this as an iterator too, but not sure if is any faster. Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this it'd probably be more efficient to use
neighbors.iter().enumerate()
for the for loop. Then we'd have the index for every step andposition_z
would have no lookup overhead. Right now this is O(n) for this lookup as you have to re-traverseneighbors
on each iteration.