Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade color-convert and color-string dependencies #133

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

brunolemos
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zbarbuto
Copy link

zbarbuto commented Nov 8, 2017

Worth mentioning that this version bump addresses a minification issue in color-convert. See: https://github.com/Qix-/color-convert/issues/50 https://github.com/Qix-/color-convert/pull/49

@Qix- Qix- merged commit cc0a477 into Qix-:master Nov 9, 2017
@Qix-
Copy link
Owner

Qix- commented Nov 9, 2017

Thanks! Published as 2.0.1.

@brunolemos brunolemos deleted the patch-1 branch November 9, 2017 01:33
@jacargentina
Copy link

I was having the React Native production build issue; when using react-native 0.50.3

Now that color 2.0.1 was released, I tried again update from react-native 0.50.0 to 0.50.3 AND color to latest 2.0.1: the build is broken

Then I tried also leave react-native on 0.50.0, and update color to 2.0.1: the build is broken

Any ideas? It seems the fix in my case makes a broken build

@Qix-
Copy link
Owner

Qix- commented Nov 9, 2017

@jacargentina Can you please provide some errors?

@zbarbuto
Copy link

zbarbuto commented Nov 9, 2017

@jacargentina Can you also do an npm list | grep color-convert to verify that there are no other dependencies that might be requiring the pre-fixed version?

@jacargentina
Copy link

@Qix- @zbarbuto I've found color-convert on other modules (previous version with the problem). Everything is ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants