Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#103]: Extend StopLossTrigger model. #104

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

wenrir
Copy link
Contributor

@wenrir wenrir commented Jun 19, 2024

Close #103 .

Overview

Extend StopLossTrigger to use valueType and triggerOnMarketMakerQuote.

Require valueType
Optional triggerOnMarketMakerQuote (Defaults to False)

Avanza API endpoint call

POST to https://www.avanza.se/_api/trading-critical/rest/stoploss/new

...
"stopLossTrigger":
{"type":"FOLLOW_UPWARDS",
"value":15,
"valueType":"PERCENTAGE",
"validUntil":"2024-07-19",
"triggerOnMarketMakerQuote":false
}
...

@wenrir wenrir changed the title [#103]: Extent StopLossTrigger model. [#103]: Extend StopLossTrigger model. Jun 19, 2024
@Qluxzz Qluxzz merged commit 8ac5e66 into Qluxzz:master Jun 20, 2024
@Qluxzz
Copy link
Owner

Qluxzz commented Jun 20, 2024

LGTM, thanks for contributing!

@wenrir wenrir deleted the 103-extend-stoplosstrigger branch June 21, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Add support for value_type and triggerOnMarketMakerQuote in StopLossTrigger
2 participants