Switch instrument search to use the POST api url. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The return models of the old and new URL are not compatible so this is also a breaking change. Running the test suite |
|
The search results all have the same output, so I merged them to use the same model. Also fixed a small issue in the transactions model (and added some bits into .gitignore that shouldn't be committed) |
|
LGTM, thanks for updating the tests and models! |
jonatanj
reviewed
Feb 6, 2025
| class SearchPrice(BaseModel): | ||
| # Most values are returned as strings. | ||
| # null values are returned as "null" | ||
| last: str|None |
There was a problem hiding this comment.
Note that this code makes the library incompatible with Python 3.9 (the minimum version stated in setup.py). See https://docs.python.org/3.10/whatsnew/3.10.html#pep-604-new-type-union-operator .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #113.