Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection graph and truncate #70

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Fix connection graph and truncate #70

merged 8 commits into from
Feb 23, 2024

Conversation

S-Linde
Copy link
Collaborator

@S-Linde S-Linde commented Feb 19, 2024

This Pull Request contains the following bugfixes:

  • Grid graph input parsing now converts node labels to integers.
  • InitialMapping is no longer truncated at the start of an episode.

jhenstra and others added 5 commits February 19, 2024 08:55
@jhenstra
Fix incorrect mapping update for routing env from grid size (#68). (#69)
c2ec400 
* Fix incorrect mapping update for routing env from grid size.

Relabel the nodes to be indexed when creating connection graph from grid size.

* Use networkx builtin function to convert node labels to integers.
@S-Linde
Styling
9b61b57
@S-Linde
Bugfix initial mappong truncation
07ee7d9
@S-Linde
Update tests
ec308bd
@S-Linde
Bump version number
5760eb9
Willem-de-kok
Willem-de-kok previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@Willem-de-kok Willem-de-kok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nothing to add!

@Willem-de-kok Willem-de-kok mentioned this pull request Feb 23, 2024
Open
Willem-de-kok
Willem-de-kok approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@Willem-de-kok Willem-de-kok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top

@S-Linde S-Linde merged commit b9047e6 into master Feb 23, 2024
9 checks passed
@S-Linde S-Linde deleted the fix-connection_graph branch February 23, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willem-de-kok Willem-de-kok Willem-de-kok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S-Linde @Willem-de-kok @jhenstra