-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QNEBE-728] Update jsonschema validator #74
Conversation
d66d75c
to
026a395
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pressed Approve button by accident. There is 1 comment
4825f91
to
6ebeeb5
Compare
b900392
to
f52a422
Compare
808431d
to
5355197
Compare
5355197
to
ff22f04
Compare
Looked through the code and the changes look good.
This is due to pinning pydantic to I would say resolving it is a separate issue from this PR but it does prevent this issue from being tested. |
Submitted a PR in SquidASM to fix pydantic there: QuTech-Delft/squidasm#37 |
Looks good. Squidasm 0.12.1 is released to pypi and installs with qne-adk without errors. Also testen schema validation of an experiment and it worked fine. |
Replace deprecated RefResolver with jsonschema referencing implementation.
NOTE: Using
type: ignore
because jsonschema 4.19 type stubs are not available. see: python/typeshed#10417