Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNEBE-728] Update jsonschema validator #74

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

cmvanb
Copy link
Contributor

@cmvanb cmvanb commented Aug 11, 2023

Replace deprecated RefResolver with jsonschema referencing implementation.

NOTE: Using type: ignore because jsonschema 4.19 type stubs are not available. see: python/typeshed#10417

@cmvanb cmvanb force-pushed the fix/qnebe-728/update-jsonschema-validator branch from d66d75c to 026a395 Compare August 11, 2023 10:55
@cmvanb cmvanb changed the title [QNEBE-728 Update jsonschema validator [QNEBE-728] Update jsonschema validator Aug 11, 2023
@cmvanb cmvanb marked this pull request as ready for review August 11, 2023 15:07
Copy link
Contributor

@QFer QFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pressed Approve button by accident. There is 1 comment

@cmvanb cmvanb force-pushed the fix/qnebe-728/update-jsonschema-validator branch from 4825f91 to 6ebeeb5 Compare August 15, 2023 07:54
@cmvanb cmvanb force-pushed the fix/qnebe-728/update-jsonschema-validator branch 2 times, most recently from b900392 to f52a422 Compare August 25, 2023 09:00
@cmvanb cmvanb force-pushed the fix/qnebe-728/update-jsonschema-validator branch 2 times, most recently from 808431d to 5355197 Compare August 25, 2023 09:21
@cmvanb cmvanb force-pushed the fix/qnebe-728/update-jsonschema-validator branch from 5355197 to ff22f04 Compare August 25, 2023 09:25
@cmvanb cmvanb requested review from QFer and bkreynen August 25, 2023 09:32
@bkreynen
Copy link

bkreynen commented Sep 1, 2023

Looked through the code and the changes look good.
However during testing I am not able to properly install it. I first install the qne adk and then SquidASM. During the SquidASM install I get the following error

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pydantic-settings 2.0.3 requires pydantic>=2.0.1, but you have pydantic 1.10.12 which is incompatible.
qne-adk 0.3.0 requires pydantic>=2.1.1, but you have pydantic 1.10.12 which is incompatible.

This is due to pinning pydantic to pydantic>=2.1.1 in the adk, but to pydantic >=1.8.2, < 2.0 in SquidASM.

I would say resolving it is a separate issue from this PR but it does prevent this issue from being tested.

@bkreynen
Copy link

Submitted a PR in SquidASM to fix pydantic there: QuTech-Delft/squidasm#37

@QFer
Copy link
Contributor

QFer commented Oct 9, 2023

Looks good. Squidasm 0.12.1 is released to pypi and installs with qne-adk without errors. Also testen schema validation of an experiment and it worked fine.

@QFer QFer merged commit 38caf97 into dev Oct 16, 2023
@QFer QFer deleted the fix/qnebe-728/update-jsonschema-validator branch October 16, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants