Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDS-610] Measurement mask field in asset deleted #141

Merged
merged 2 commits into from
May 13, 2022
Merged

[SDS-610] Measurement mask field in asset deleted #141

merged 2 commits into from
May 13, 2022

Conversation

QFer
Copy link
Contributor

@QFer QFer commented May 10, 2022

  • Deleted the descripton of the (deleted) field measurement mask in asset (method get_asset in api.py)
  • Added fields url and author_email to setup (warning seen in last release)
  • Changed to return as early as possible when no mapper installed (unresolved review comment earlier)

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 100.0% when pulling db87922 on feature/sds-610/delete_measurement_mask_asset into 24a5542 on dev.

@QFer QFer requested a review from tomrijnbeek May 13, 2022 06:49
@QFer QFer merged commit a15919b into dev May 13, 2022
@QFer QFer deleted the feature/sds-610/delete_measurement_mask_asset branch May 13, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomrijnbeek tomrijnbeek tomrijnbeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QFer @coveralls @tomrijnbeek