Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search input modal allows user to tab away from it without explicitly dismissing it #83

Open
Tracked by #72
gabalafou opened this issue May 28, 2024 · 0 comments
Open
Tracked by #72

Search input modal allows user to tab away from it without explicitly dismissing it #83

gabalafou opened this issue May 28, 2024 · 0 comments
Assignees
@gabalafou
Labels
area: accessibility ♿ area: PyData-Sphinx size: M One to two weeks

Comments

@gabalafou
Copy link
Contributor

gabalafou commented May 28, 2024 •
edited by trallard
Loading

x-ref to user's feedback on PST pydata/pydata-sphinx-theme#1403
@gabalafou gabalafou mentioned this issue May 28, 2024
Open
@gabalafou gabalafou changed the title Search input modal allows user to tab away from it without explicitly dismissing it [S] Search input modal allows user to tab away from it without explicitly dismissing it May 30, 2024
@gabalafou gabalafou changed the title [S] Search input modal allows user to tab away from it without explicitly dismissing it [M] Search input modal allows user to tab away from it without explicitly dismissing it May 30, 2024
@gabalafou gabalafou moved this from 📬 TODO to Dev in czi-scientific-python 🐍 May 31, 2024
@gabalafou gabalafou added size: S A few hours, less than one week size: M One to two weeks and removed size: S A few hours, less than one week labels May 31, 2024
@trallard trallard moved this from Dev to 📬 TODO in czi-scientific-python 🐍 Jun 4, 2024
@gabalafou gabalafou changed the title [M] Search input modal allows user to tab away from it without explicitly dismissing it Search input modal allows user to tab away from it without explicitly dismissing it Jun 5, 2024
@gabalafou gabalafou moved this from 📬 TODO to 🏗 In progress in czi-scientific-python 🐍 Jul 3, 2024
@gabalafou gabalafou self-assigned this Jul 3, 2024
@gabalafou gabalafou moved this from 🏗 In progress to 📬 TODO in czi-scientific-python 🐍 Jul 4, 2024
@gabalafou gabalafou moved this from 📬 TODO to 🏗 In progress in czi-scientific-python 🐍 Jul 4, 2024
@gabalafou gabalafou mentioned this issue Jul 17, 2024
Merged
1 task
@gabalafou gabalafou moved this from 🏗 In progress to 👀 In review in czi-scientific-python 🐍 Jul 18, 2024
Carreau pushed a commit to pydata/pydata-sphinx-theme that referenced this issue Jul 25, 2024
@gabalafou
Apply modal pattern to search box pop-up (#1932)
72a756d 
Closes external issue
Quansight-Labs/czi-scientific-python-mgmt#83.

### Summary

This PR implements the pop-up search field as an HTML-native `<dialog>`.
This somewhat simplifies our implementation and brings accessibility
affordances with it.

I also introduced a couple visual changes, which fix #1714.
@gabalafou gabalafou moved this from 👀 In review to 💪🏾 Done in czi-scientific-python 🐍 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabalafou gabalafou

Labels
area: accessibility ♿ area: PyData-Sphinx size: M One to two weeks
Projects
czi-scientific-python 🐍
Status: 💪🏾 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabalafou @trallard