Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx migrate latest #723

Closed
wants to merge 49 commits into from
Closed

Nx migrate latest #723

wants to merge 49 commits into from

Conversation

gabalafou
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consulting ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 2:50pm
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 2:50pm

@bskinn
Copy link
Contributor

bskinn commented Apr 27, 2023

Any specific review actions here, @gabalafou, other than a scan across both built sites?

Copy link
Contributor

@bskinn bskinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another possibility for rollup

"postcss": "8.4.19",
"prettier": "2.8.7",
"react-test-renderer": "18.2.0",
"sass": "1.55.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabalafou #646 bumps sass to 1.58.0. Is there a reason this only goes to 1.55.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly moot given #486

Copy link
Contributor

@bskinn bskinn May 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#646 now obsoleted by #732 (but, as noted, both possibly moot b/c #486)

@bskinn bskinn added the area: dependencies 📦 Pull requests that update a dependency file label Jun 15, 2023
@gabalafou
Copy link
Contributor Author

I think too much has happened on the develop branch since I opened this PR. I'm going to start over from scratch, using this PR as a guide rather than the foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants