-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLOG] PyData Sphinx Theme Accessibility Fixes #867
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e6d6bec
[BLOG] PyData Sphinx Theme Accessibility Fixes
gabalafou 74ca388
Apply suggestions from code review
gabalafou 858d38f
edits
gabalafou 37cb8d5
suggestions
gabalafou 57e44cf
cap image widths to 1000px
gabalafou 8228762
copy edits
gabalafou a1b6894
add featured image from Disabled and Here
gabalafou e2458a4
add link to original image
gabalafou 6964824
add image credit to alt text
gabalafou 7ea5375
update publish date
gabalafou ff8671f
more copy edits
gabalafou d21fcbd
Use the same image for hero and featured. Move image credit up.
gabalafou 03a38d5
title reword (and a few other rewords)
gabalafou 1cc90db
another reword
gabalafou 1ccdaab
fix link
gabalafou e12ffba
retitle + CZI
gabalafou 45c4616
fix link
gabalafou c264d25
reword
gabalafou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.4 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/chrome-button-focus-ring.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+78.1 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-copy-button-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+75.9 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-copy-button-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+108 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-dropdown-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+105 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-dropdown-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.87 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-frankenstate-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.93 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-frankenstate-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.1 KB
.../labs/public/posts/pydata-theme-a11y-fixes/focus-ring-header-nav-link-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.22 KB
...labs/public/posts/pydata-theme-a11y-fixes/focus-ring-header-nav-link-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+77.1 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-left-toc-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+76.6 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-left-toc-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+59.3 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-more-dropdown-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+58.9 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-more-dropdown-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+59.2 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-right-toc-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+59.9 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-right-toc-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.9 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-tile-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.7 KB
apps/labs/public/posts/pydata-theme-a11y-fixes/focus-ring-tile-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+65.4 KB
...abs/public/posts/pydata-theme-a11y-fixes/focus-ring-toggle-admonition-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+63.7 KB
...bs/public/posts/pydata-theme-a11y-fixes/focus-ring-toggle-admonition-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+33.8 KB
...labs/public/posts/pydata-theme-a11y-fixes/focus-ring-version-dropdown-after.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+32.5 KB
...abs/public/posts/pydata-theme-a11y-fixes/focus-ring-version-dropdown-before.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+581 KB
...posts/pydata-theme-a11y-fixes/magnification-app-sherm-for-disabled-and-here.png
Oops, something went wrong.
Binary file added
BIN
+211 KB
...s/public/posts/pydata-theme-a11y-fixes/sidebar-toc-after-1-ring-around-link.png
Oops, something went wrong.
Binary file added
BIN
+211 KB
...public/posts/pydata-theme-a11y-fixes/sidebar-toc-after-2-ring-around-toggle.png
Oops, something went wrong.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made these changes to make local dev work. Next.js deprecated the style on the left.