Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable display of Qhub version #1256

Merged
merged 3 commits into from
May 5, 2022
Merged

Enable display of Qhub version #1256

merged 3 commits into from
May 5, 2022

Conversation

viniciusdc
Copy link
Contributor

Fixes | Closes | Resolves #555

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

As we are bumping the qhub-jupyterhub-version that depends over these changes, we need to be sure Quansight/qhub-jupyterhub-theme#13 was merged and a new release was made

@costrouc
Copy link
Member

@viniciusdc I'm waiting to review this PR until a release of qhub-jupyterhub-theme is released.

@magsol magsol added this to the Release v0.4.1 milestone Apr 26, 2022
@viniciusdc viniciusdc requested a review from costrouc May 4, 2022 22:25
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viniciusdc, this looks great!

Could you fix the typo, and then feel free to merge :)

@viniciusdc
Copy link
Contributor Author

Thanks @viniciusdc, this looks great!

Could you fix the typo, and then feel free to merge :)

This linter is falling due to a broken link that was fixed in #1269 (this branch only does not have those changes, so that's why the action is complaining )

@iameskild
Copy link
Member

iameskild commented May 5, 2022

@viniciusdc I'm not sure why it's not appearing in the "check" above but going to the files changed, you will see what I mean. There are other misspellings in files you didn't touch but don't worry about those.

https://github.com/Quansight/qhub/pull/1256/files

@viniciusdc
Copy link
Contributor Author

@viniciusdc I'm not sure why it's not appearing in the "check" above but going to the files changed, you will see what I mean. There are other misspellings in files you didn't touch but don't worry about those.

https://github.com/Quansight/qhub/pull/1256/files

Let's move those fixes to another issue and fix those later (I think some were already managed by newer changes to the main that are not reflected here). For now, lets just disregard those typos 😝

@iameskild iameskild merged commit d16b982 into main May 5, 2022
@iameskild iameskild deleted the fix-555-theme branch May 5, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version tag to qhub header
4 participants