Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont create DB session as dependency #138

Merged
merged 2 commits into from
Nov 1, 2023
Merged

dont create DB session as dependency #138

merged 2 commits into from
Nov 1, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Oct 31, 2023

This is a "better safe than sorry" PR that addresses #136. I still need to do a proper investigation if this is actually needed. However, the solution in this PR works flawlessly as reported by other users that faced the same issue. Thus, in interest of time, let's go with this for now, even it if its slightly less elegant.

@pmeier pmeier requested a review from nkaretnikov October 31, 2023 22:10
nkaretnikov
nkaretnikov approved these changes Nov 1, 2023
View reviewed changes
Copy link

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I've only done a surface-level review. If there are problems later, I'd look into how make_session() is defined.

@pmeier pmeier merged commit 17c227e into main Nov 1, 2023
9 checks passed
@pmeier pmeier deleted the safe-session branch November 1, 2023 09:13
pierrotsmnrd added a commit that referenced this pull request Nov 1, 2023
@pierrotsmnrd
Squashed commit of the following:
3cd9a20 
commit 9b721fd
Author: Philip Meier <github.pmeier@posteo.de>
Date:   Wed Nov 1 14:08:20 2023 +0100

    allow API token secret to be set through env var (#141)

commit 17c227e
Author: Philip Meier <github.pmeier@posteo.de>
Date:   Wed Nov 1 10:13:08 2023 +0100

    dont create DB session as dependency (#138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkaretnikov nkaretnikov nkaretnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @nkaretnikov