Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assistant timeout to accomodate longer response time. #184

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

petrpan26
Copy link
Contributor

@petrpan26 petrpan26 commented Nov 8, 2023

Relating to:
#174

An improvement idea is that we can have streaming input check for those api that support this (e.g GPT). This way we know that it's still generating output rather than a network problem.

Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @petrpan26!

An improvement idea is that we can have streaming input check for those api that support this (e.g GPT).

Unfortunately, this is not really possible or will be a lot harder than you might think. I would very much like to have this feature and have played around with it in the past.

This is so hard, because we receive the response on the worker, but consume it on the API side. In between them is our result storage. Meaning, we would need to somehow implement a streaming approach for the results and finally also implement streaming on our own API.

If you want to have a go at this, be my guest. But be warned that this likely could turn really ugly.

@pmeier pmeier linked an issue Nov 8, 2023 that may be closed by this pull request
@pmeier pmeier merged commit b103027 into Quansight:main Nov 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase API assistant timeout
2 participants