make config optional when creating a component #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel it is kinda annoying to always pass a config when trying to instantiate a component, e.g. #189 (comment). There should be no harm to provide a default. When the components are instantiated for the queue we always pass a config
ragna/ragna/core/_queue.py
Lines 126 to 130 in dc497ef
Meaning, we can be sure that all components that are used "in process" receive the right config.