Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove [BUG] and [ENH] classifier from issue templates #228

Merged
merged 2 commits into from
Dec 4, 2023
Merged

remove [BUG] and [ENH] classifier from issue templates #228

merged 2 commits into from
Dec 4, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Dec 4, 2023

Having these prefixes is redundant with our labels. We shouldn't have both.

@pmeier pmeier requested a review from pavithraes December 4, 2023 16:05
@pavithraes pavithraes added the type: maintenance 🛠️ Day-to-day maintenance tasks label Dec 4, 2023
pavithraes
pavithraes approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. :)

I'll note that there's a failing test that seems unrelated, but you may have a better idea about that.

@pmeier pmeier merged commit b2730f1 into main Dec 4, 2023
9 of 10 checks passed
@pmeier pmeier deleted the issue-templates branch December 4, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithraes pavithraes pavithraes approved these changes

Assignees
No one assigned
Labels
type: maintenance 🛠️ Day-to-day maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @pavithraes