Cleanup UI code #261
Merged
Cleanup UI code #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
reviewed
Dec 21, 2023
ahuang11
reviewed
Dec 21, 2023
pmeier
commented
Jan 3, 2024
pierrotsmnrd
approved these changes
Jan 4, 2024
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #215, I found it really difficult to add the change to the UI. For the most part I was confused how the chat interface was actually used. So I looked more into it with the goal of understanding how it works to be able to implement #215. And doing that lead to this PR, which majorly cleans up our code.
There are still a few things I dislike, e.g. are calling private APIs of panel, but I think this is the best we can do for now. I've marked these places as
#TODO: @panelto eventually discuss with them.