Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return source content from the REST API #264

Merged
merged 7 commits into from
Jan 18, 2024
Merged

return source content from the REST API #264

merged 7 commits into from
Jan 18, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Jan 11, 2024

Closes #248. Since we need to touch the database tables, this will not work with existing ones without handling. I'm going to open a separate issue for that. Edit: See #265.

I need help styling the accordion in the UI. By default it looks like

Screenshot from 2024-01-11 09-46-04

The color is off and the title doesn't seem to support Markdown. We don't actually need Markdown, but some way to make the part in **...** bold. When opening an item we also have another issue:

Screenshot from 2024-01-11 09-46-32

If long enough, the content of the first item happily expands behind the other items. We should probably make it scrollable.

@smeragoel is working on a design for this.

@pmeier pmeier requested a review from pierrotsmnrd January 11, 2024 09:00
@pmeier
Copy link
Member Author

pmeier commented Jan 18, 2024

Thanks a ton @pierrotsmnrd, looks great!

@pmeier pmeier linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link
Contributor

@pierrotsmnrd pierrotsmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested locally, it works.

@pmeier pmeier merged commit 3526e4c into main Jan 18, 2024
10 checks passed
@pmeier pmeier deleted the source-content branch January 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants