-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using .docx files #281
Conversation
Looks like type checks failed because of the import of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paskett for the PR and for the discipline to add a test. We are very much aware that our test suite is let's call it "minimal" at the moment. Good thing you are not following our example. I promise, we'll get better at that. 😇
I've left a bunch of minor comments, but overall LGTM!
This is a quite common thing and the best solution here is to ignore this package globally. YOu can add it here Lines 138 to 146 in c08a223
|
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
I'll get some of those suggestions committed when I have a chance later tonight (~20:00 MST) |
@pmeier Got all the suggestions put in and pipeline passing, let's ship it! 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paskett. The PR is almost ready with one question left below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @paskett, somehow my actual comment got lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paskett!
@pmeier If you could check out the test I added, let me know if you think that's sufficient.
Resolves #225