-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add tutorial for adding your own objects #368
[DOC] Add tutorial for adding your own objects #368
Conversation
This is just a first draft what will be iterated on later Remove small typo
- Add subheading - Shorten long lines
…link to correct method
228e6a0
to
88c95d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed most of my own comments. There is some slight cleanup needed, but this is good for a first round of review from someone else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Most of the suggestions are related to language being used, specifically avoiding phrases like simply or just and using active voice.
I have a note on my end to improve the existing tutorials to also use second person in the tutorials (i.e. "you" rather than "we") on this project, so not including those as review suggestions here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, looks good to me :)
Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
This is a work in progress.
This is a continuation of PR #358. It was created by rebasing PR #358 to include the merged commits from PR #362 that removes
max_input_size
.This PR adds a tutorial to help users or developers add assistants and source storages for LLMs to Ragna that are not currently supported.
TODO: Add usage example with the Python API