Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated get_component error message from 404 to 422 #374

Merged

Conversation

Tengal-Teemo
Copy link
Contributor

Changed a single number

@Tengal-Teemo Tengal-Teemo changed the title updtaed get_component error message from 404 to 422 updated get_component error message from 404 to 422 Mar 20, 2024
pmeier
pmeier previously approved these changes Mar 20, 2024
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmeier pmeier dismissed their stale review March 20, 2024 23:03

CI is failing

Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the corresponding test as well:

assert response.status_code == status.HTTP_404_NOT_FOUND

@Tengal-Teemo
Copy link
Contributor Author

Sorry @pmeier will fix immediately

Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tengal-Teemo!

@pmeier pmeier merged commit a5e4795 into Quansight:main Mar 25, 2024
10 checks passed
pmeier added a commit that referenced this pull request Jun 28, 2024
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants