use custom JSON type for database for more generic support #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint errors are unrelated. See #390. |
pierrotsmnrd
added a commit
that referenced
this pull request
May 13, 2024
commit 04168ab Author: Arjun Verma <arjunverma.oc@gmail.com> Date: Wed May 1 12:35:41 2024 +0530 #373 Include documentation_helpers in module (#395) Co-authored-by: Philip Meier <github.pmeier@posteo.de> commit f947f2d Author: Philip Meier <github.pmeier@posteo.de> Date: Mon Apr 29 17:08:40 2024 +0200 bump mypy to 1.10 (#398) commit e0fe014 Author: Kevin Klein <7267523+kklein@users.noreply.github.com> Date: Mon Apr 29 12:52:49 2024 +0200 Add instructions to install from conda-forge. (#396) Co-authored-by: Philip Meier <github.pmeier@posteo.de> commit 7963453 Author: Philip Meier <github.pmeier@posteo.de> Date: Thu Apr 25 20:38:50 2024 +0200 use custom JSON type for database for more generic support (#389) commit 3a5b82d Author: William Black <125844868+smokestacklightnin@users.noreply.github.com> Date: Wed Apr 24 01:37:48 2024 -0700 Remove Mosaic Assistant (#387)
pmeier
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline report by @nenb.
sqlalchemy.types.JSONsupportsThus, using Ragna with a DB like snowflake is impossible.
This PR implements a custom
Jsontype that augmentstypes.Stringthat does nothing but serializing incoming values and deserializing them again on the way out.This breaks BC so we shouldn't include this in any potential bug fix release until
0.3.