mypy for sqlalchemy #402
Merged
mypy for sqlalchemy #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
type: maintenance 🛠️
pmeier
commented
May 3, 2024
| @@ -211,7 +211,7 @@ def update_chat(session: Session, user: str, chat: schemas.Chat) -> None: | |||
| orm_chat = _get_orm_chat(session, user=user, id=chat.id) | |||
|
|
|||
| orm_chat.prepared = chat.prepared | |||
| orm_chat.messages = [ | |||
| orm_chat.messages = [ # type: ignore[assignment] | |||
There was a problem hiding this comment.
mypy incorrectly infers orm.Chat.messages to be of type orm.Message rather than the correct list[orm.Message]. Thus, we just silence it here.
pmeier
added a commit
that referenced
this pull request
Jun 28, 2024
pmeier
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the lint issues of #401, I realized we never activated the SQLAlchemy mypy plugin. This PR makes up for that.
This surfaces some errors. When columns are defined without
nullable=False, the value of the field is alwaysOptional[T]. Since we don't haveNonevalues and won't have them for the currently available columns in the future, I've setnullable=Falseeverywhere.