Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QC PythonNet 2.0 #5376

Merged
merged 8 commits into from
Mar 9, 2021
Merged

QC PythonNet 2.0 #5376

merged 8 commits into from
Mar 9, 2021

Conversation

C-SELLERS
Copy link
Contributor

@C-SELLERS C-SELLERS commented Mar 9, 2021 •
edited by Martin-Molinero
Loading

Description

Update Lean to use the newly published QC PythonNet 2.0

Related Issue

Related to #452
Closes #1696

Motivation and Context

Upgrade PythonNet with our customizations to bring us closer to root PythonNet.

Some additions in this version of PythonNet:

  • KWargs (Named Args)
  • Params Array
  • Optional args
  • DotNet core support

Changes to Lean:

  • Use QC.PythonNet 2.0
  • All OS's use the same PythonNet dlls so removed all file selecting logic
  • Automated deployment by content files, again no need to copy in csproj files
  • Python test adjustments (only 3)
  • LocalPackages dev/deployment directory (Simplifies testing newly built packages with Lean, CI/CD friendly)
  • Python readme update for new process of setting up Python, (simpler overall)
  • Update LeanFoundation image with new environment variable (PYTHONNET_PYDLL)
  • Update travis yml to reflect new env var and LocalPackages

Requires Documentation Change

Readme update to show how to setup Python with Lean

How Has This Been Tested?

Cloud tested using backtesting, live and research
Locally tested through all regressions windows and linux

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

C-SELLERS
C-SELLERS commented Mar 9, 2021
View reviewed changes
Copy link
Contributor Author

@C-SELLERS C-SELLERS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed! Everything looks good to me 😄

@Martin-Molinero Martin-Molinero merged commit 834d4a4 into QuantConnect:master Mar 9, 2021
This was referenced Mar 9, 2021
Closed
Merged
hsm207 pushed a commit to hsm207/Lean that referenced this pull request Mar 25, 2021
@C-SELLERS
QC PythonNet 2.0 (QuantConnect#5376)
43ad21e 
* Update to new QC PythonNet

* Update readme

* Remove Python.Runtime config, replaced by env var

* Allow local packages testing in repo

* Address Review

* Add the LocalPackages readme

* Update Jupyter Image

* Update Research ReadMe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin-Molinero Martin-Molinero Martin-Molinero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Named arguments in python algorithms
2 participants
@C-SELLERS @Martin-Molinero