Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pythonnet version #8021

Merged
merged 2 commits into from
May 15, 2024

Conversation

jhonabreul
Copy link
Collaborator

@jhonabreul jhonabreul commented May 14, 2024

Description

Update Pythonnet version to 2.0.37 after QuantConnect/pythonnet#92 to fix #8011 and other bugs.

Algorithm.Python/CustomDataPropertiesRegressionAlgorithm.py was slightly modifed to reproduce the bug in #8011. The bug reproduced when the method is called with named arguments and has to do with the types of overloads it has. Multiple unit tests were added in QuantConnect/pythonnet#92 reproducing the bug.

Related Issue

Close #8011

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Existing test suite

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jhonabreul jhonabreul merged commit c82573a into QuantConnect:master May 15, 2024
7 checks passed
@jhonabreul jhonabreul deleted the bug-8011-pyton-overloads branch May 15, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overloaded AddData Method Broken
2 participants