Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor functionalities and files #19

Merged
merged 14 commits into from
Jun 21, 2024
Merged

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Jun 14, 2024

Refactor s3contents.ts file and use an additional s3.ts file to store functions using the AWS SDK commands. Refactor these functions such that they can be reused and redundant code is eliminated (e.g. : use the same S3 function to save or create a new file, with different parameters).

Replace logic for path manipulation to use the official functions from the PathExt namespace.

Add descriptions to all S3 functions and smaller helping comments.

@DenisaCG DenisaCG added the enhancement New feature or request label Jun 15, 2024
@DenisaCG DenisaCG self-assigned this Jun 15, 2024
@DenisaCG DenisaCG requested a review from afshin June 18, 2024 23:44
@DenisaCG DenisaCG merged commit e386954 into QuantStack:main Jun 21, 2024
6 checks passed
@DenisaCG DenisaCG deleted the refactor branch June 21, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant