-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major CI cleanup #674
Major CI cleanup #674
Conversation
The current state of this PR runs the CI on every PR commit for all systems. If we want to limit this depending on if it is a PR or if it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks a lot for the cleanup.
Regarding whether we want to run builds on all architecture for every branch/PR, I think the original reason was that MacOS and Windows runners are much more expensive and we don't need it as much. Let's try it with your approach and reevaluate later whether we want to restrict them again.
My main comment is about the frequency at which we run the conda-build CI. I think right now it would basically only run when we merge a PR (if this PR doesn't modify the CI files). I think we should run it more often.
I might be wrong here but are we even paying for the CI resources in this repo since it is open-source? @xhochy |
No description provided.