Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT use dataclass for IRLSData #881

Merged
merged 4 commits into from
Nov 22, 2024
Merged

MNT use dataclass for IRLSData #881

merged 4 commits into from
Nov 22, 2024

Conversation

lorentzenchr
Copy link
Contributor

A small neat maintenance PR using a dataclass decorator for IRLSData.

MarcAntoineSchmidtQC
MarcAntoineSchmidtQC approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC merged commit 4ac443b into Quantco:main Nov 22, 2024
22 checks passed
@lorentzenchr lorentzenchr deleted the dataclass branch November 22, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC MarcAntoineSchmidtQC approved these changes

@jtilly jtilly Awaiting requested review from jtilly jtilly is a code owner

@lbittarello lbittarello Awaiting requested review from lbittarello lbittarello is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentzenchr @MarcAntoineSchmidtQC