Fixes issue #719, savReaderWriter including headers in data

[geirfreysson]

I don't know if you guys are having this problem but whenever I try and read an SPSS file with the latest savReaderWriter it throws an error because it includes the first line (the header) in the data being read.

This pull request is a fix for that. We check for the version of savReaderWriter being used and if it is a recent one, we start reading after line 0 (i.e. the header).

[jamesrkg]

@geirfreysson we're not on the most recent version but I'm going to take a look at this. We've done some lib updates recently and it would be better for us to update if we can.

[jamesrkg]

@geirfreysson can we achieve this without adding packaging as a dependency?

>>> import savReaderWriter as srw
>>> srw.version
'3.3.0'

[geirfreysson]

Yes, it can be done without the 3rd party package. Do you think, @jamesrkg, that I should replace the packaging method with distutils.version?

According to this stack overflow answer:

Use distutils.version or packaging.version.parse.

Differences between the two options:

• distutils.version is built in but is undocumented and conformant only to the superseded PEP 386;
• packaging.version.parse is a third-party utility but is used by setuptools (so you probably already have it installed) and is conformant to the current PEP 440; it also handles "loose" and "strict" versions in a single function (although "legacy" versions will always sort before valid versions).

[jamesrkg]

@geirfreysson I'll add packages as a dependency and merge this PR on Friday. 👍

[geirfreysson]

Hurray!

…

On Mon, 27 Mar 2017 at 18:29, James Griffiths ***@***.***> wrote: @geirfreysson <https://github.com/geirfreysson> I'll add packages as a dependency and merge this PR on Friday. 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#720 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAASFsvhomHPgE6-XcCkbuE57PkhO5tdks5rp7OrgaJpZM4MNDOW> .