-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounded rectangle #81
Rounded rectangle #81
Conversation
+ std::ops::Div<f32, Output = T> | ||
{ | ||
/// Returns true if the specified point is inside this rounded rectangle. | ||
/// Note: this is always inclusive, in contrast to the `contains` method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the behaviour consistent (this should also be exclusive)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about how to handle the curves: there isn't a real "bottom" if the corner is a curve. By "exclusive" do you mean that instead of always inclusive it should be always exclusive? In which case it would be different from the Rectangle's contains() anyways
on it |
Perfect, thanks again for this! If you have any questions please let me know. |
20896a9
to
86f77f2
Compare
Hey @dennisorlando, thanks for making the changes! Just checking if this is ready for re-review? It looks like there's a merge conflict in |
Hey :) I think so (?) there's the exclusivity / inclusivity problem of the "contains" method that is left unsolved; I left it as it is, therefore always inclusive |
(I made some mess with branches and merges because of inexperience, I made a new branch and created a new pull request) |
I don't think I know how to complete the various missing "draw_rounded_*" functions: it would be lovely if someone else knows how to write them :3 (perhaps a new "rounded_rectangle" branch?)