Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login on new firmware #127

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Fix login on new firmware #127

merged 12 commits into from
Aug 7, 2023

Conversation

QuantumEntangledAndy
Copy link
Owner

@QuantumEntangledAndy QuantumEntangledAndy commented Aug 4, 2023

Seems that something is up with login on latest firmware. This PR will try to address that (also fix some other bugs)

  • Fixes issue with simulataenous subscrption of discovery message handler.
    Now that all discovery happens with a single handller special care needs to be done to handle the case where multiple threads subscribe to all messages
  • Use new contentless login packet
  • Don't send -1 ack packets

@QuantumEntangledAndy QuantumEntangledAndy changed the title Fix simultaneous discovery subscription Fix login on new firmware Aug 4, 2023
@QuantumEntangledAndy
Copy link
Owner Author

QuantumEntangledAndy commented Aug 6, 2023

It seems the new firmware won't accept the 0x02 encryption algorithm and is now using just 0x12. I will have to work out what is going on with it....

@QuantumEntangledAndy
Copy link
Owner Author

QuantumEntangledAndy commented Aug 7, 2023

Success! The 0x12 encryption algorithm patially encrypts the media packets. Binary data can now be encryted if the encryptionLen is set in the meta data of the packet. Encryption is with the same method as the xml payloads which was, in this case, AES.

@QuantumEntangledAndy QuantumEntangledAndy merged commit a380212 into master Aug 7, 2023
32 checks passed
@QuantumEntangledAndy QuantumEntangledAndy deleted the fix/sim_sub_disc branch August 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant