Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivariate Bicycle code via Hecke's Group Algebra #381

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 5, 2024

This PR implements all the Multivariate Bicycle (MB) using Lifted Product construction and use of Oscar Product of Groups from the paper Multivariate Bicycle Codes. All the MB code constructions from Appendix A Table 2 can be verified using the construction method presented.

Many thanks to Sim J. Xian for clarifying something explicitly, it was an important detail about construction which seemed to be missing from their paper since they only mentioned order l and m, for two cyclic groups. That third generator is z=xy . I was wondering for some time the order of the third cyclic group for the codes to be MB code: 𝐺ᵣ = ℤ/l₁ × ℤ/l₂ × ℤ/l₃ as only l and m, order of first two cyclic groups, were mentioned in their paper explicitly.

With z=xy, the codes can be constructed with correct code_n and code_k parameters.

I have added doctests for Weight-7 and Weight-6 MB codes, which give correct results for code_n and code_k values.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 5, 2024

I think the PR is ready for review. Thank you!

@Fe-r-oz Fe-r-oz changed the title Multivariate Bicycle (MB) code using Lifted Product construction and Oscar's Product of Groups Multivariate Bicycle (MB) code using Lifted Product construction via Hecke's Group Algebra Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (be50f9c) to head (66e4891).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          70       70           
  Lines        4410     4410           
=======================================
  Hits         3663     3663           
  Misses        747      747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 18, 2024

Since #394 is fixed, added the tests that reproduce all the results from Table 1 for these codes.

@Fe-r-oz Fe-r-oz changed the title Multivariate Bicycle (MB) code using Lifted Product construction via Hecke's Group Algebra Multivariate Bicycle code via Hecke's Group Algebra Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant