-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multivariate Bicycle code via Hecke's Group Algebra #381
Open
Fe-r-oz
wants to merge
4
commits into
QuantumSavory:master
Choose a base branch
from
Fe-r-oz:mbbcode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the PR is ready for review. Thank you! |
4 tasks
…Oscar Product of Groups
Fe-r-oz
changed the title
Multivariate Bicycle (MB) code using Lifted Product construction and Oscar's Product of Groups
Multivariate Bicycle (MB) code using Lifted Product construction via Hecke's Group Algebra
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 70 70
Lines 4410 4410
=======================================
Hits 3663 3663
Misses 747 747 ☔ View full report in Codecov by Sentry. |
Since #394 is fixed, added the tests that reproduce all the results from Table 1 for these codes. |
Fe-r-oz
changed the title
Multivariate Bicycle (MB) code using Lifted Product construction via Hecke's Group Algebra
Multivariate Bicycle code via Hecke's Group Algebra
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements all the Multivariate Bicycle (MB) using Lifted Product construction and use of Oscar Product of Groups from the paper Multivariate Bicycle Codes. All the MB code constructions from Appendix A Table 2 can be verified using the construction method presented.
Many thanks to Sim J. Xian for clarifying something explicitly, it was an important detail about construction which seemed to be missing from their paper since they only mentioned order
l
andm
, for two cyclic groups. That third generator isz=xy
. I was wondering for some time the order of the third cyclic group for the codes to be MB code:𝐺ᵣ = ℤ/l₁ × ℤ/l₂ × ℤ/l₃
as onlyl
andm
, order of first two cyclic groups, were mentioned in their paper explicitly.With
z=xy
, the codes can be constructed with correctcode_n
andcode_k
parameters.I have added doctests for Weight-7 and Weight-6 MB codes, which give correct results for
code_n
andcode_k
values.