add sourceTokenAddress #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyl19970726
approved these changes
Dec 24, 2021
cyl19970726
approved these changes
Dec 24, 2021
zhiqiangxu
reviewed
Dec 24, 2021
contracts/app/Bridge.sol
Outdated
| BridgeLib.TransferData memory transferData, | ||
| bytes32[] memory proof | ||
| ) public { | ||
| // safemath not needed for solidity 8 | ||
| uint256 amountPlusFee = (transferData.amount * | ||
| (10000 + CONTRACT_FEE_BASIS_POINTS)) / 10000; | ||
| IERC20(transferData.tokenAddress).safeTransferFrom( | ||
| IERC20(sourceTokenAddress).safeTransferFrom( |
There was a problem hiding this comment.
I think evil things can happen if designed like this...
There was a problem hiding this comment.
Seems the token mapping has to be centralized, can't be decentralized..
add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to allow token mapping from source to destination by user (in general the tokens on the source and target chains are different).