transfer native token to sourceTokenAddress #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyl19970726 <15258378443@163.com>
Signed-off-by: cyl19970726 <15258378443@163.com>
Signed-off-by: cyl19970726 <15258378443@163.com>
qizhou
reviewed
Dec 23, 2021
contracts/app/Bridge.sol
Outdated
| } | ||
|
|
||
| function buy(TransferKey memory tkey) public { | ||
| function buy(TransferKey memory tkey) public payable{ |
|
Further, please use npm run prettier:fix to auto-format the code. |
Signed-off-by: cyl19970726 <15258378443@163.com>
Signed-off-by: cyl19970726 <15258378443@163.com>
Signed-off-by: cyl19970726 <15258378443@163.com>
qizhou
reviewed
Dec 24, 2021
| ) { | ||
| return transferData.fee; | ||
| } else { | ||
| return transferData.fee * (currentTime - transferData.startTime); |
There was a problem hiding this comment.
Suggested change
| return transferData.fee * (currentTime - transferData.startTime); | |
| return transferData.fee * (currentTime - transferData.startTime) / transferData.feeRampup; |
|
|
||
| if (tkey.transferData.tokenAddress == address(0)) { | ||
| require(msg.value >= amount, "not enough msg.value"); | ||
| payable(tkey.transferData.destination).transfer(amount); |
There was a problem hiding this comment.
may need nonReentrant to avoid reentrancy attack?
modify BridgeDestination.getLPFee() Co-authored-by: Qi Zhou <qizhou@quarkchain.org>
add nonReentrant to BridgeDestination.withdraw() and BridgeDestination.buy() Signed-off-by: cyl19970726 <15258378443@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cyl19970726 15258378443@163.com