Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6: Add support for networkinformation plugins #791

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

rgriebl
Copy link
Contributor

@rgriebl rgriebl commented Jan 31, 2024

Qt 6.1 added https://doc.qt.io/qt-6/qnetworkinformation.html to the network module, but this needs plugins in networkinformation to be deployed.

Qt 6.1 added https://doc.qt.io/qt-6/qnetworkinformation.html to the network module, but this needs plugins in `networkinformation` to be deployed.

Signed-off-by: rgriebl <robert@griebl.org>
@EndrII
Copy link
Member

EndrII commented Jan 31, 2024

Tanks you, but this fixes require changes in the tests cases
can you add into qt6.3 cases new plugins for window and Linux ?

Just see how it implemented for the TLS plugin of network.

Signed-off-by: rgriebl <robert@griebl.org>
@EndrII
Copy link
Member

EndrII commented Feb 1, 2024

@rgriebl looks as the Qt 6.5 or higher contains libqglib in the networkinformation plugin module

Please add into qt6.5 module this library into qtLibs test cases. It should b help.

QCRITICAL: tstMain::qmlfiledialogtest() "added unnecessary file : /mnt/storage/Workers/ubuntu20/cmake/LinuxCMakeBuilderQt6/QuasarApp/CQtDeployer/Testing/CQtDeployer/DistributionKit/plugins/networkinformation/libqglib.so"
FAIL!  : tstMain::qmlfiledialogtest() 'false' returned FALSE. (runTestParams fail)
   Loc: [/mnt/storage/Workers/ubuntu20/cmake/LinuxCMakeBuilderQt6/QuasarApp/CQtDeployer/tests/units/testbase.cpp(130)]

@EndrII EndrII self-requested a review February 1, 2024 08:13
Copy link
Member

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add libqglib into linux-test (Qt 6.5)

@EndrII
Copy link
Member

EndrII commented Feb 5, 2024

okay, I will fix it itself ...

@EndrII EndrII merged commit eb3a750 into QuasarApp:main Feb 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants