Support DNF5 UpdateVM for qvm-template #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimirjamali
force-pushed
the
DNF5-qvm-template
branch
from
a8558e4 to
4fd2520
Compare
|
Making pylint happy(er) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 75.09% 75.10%
=======================================
Files 52 52
Lines 8541 8552 +11
=======================================
+ Hits 6414 6423 +9
- Misses 2127 2129 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alimirjamali
force-pushed
the
DNF5-qvm-template
branch
5 times, most recently
from
66dfa6d to
b3c203d
Compare
|
It did take some time to write the proper unittest but all checks are green now. This is ready for review |
marmarek
reviewed
Sep 27, 2024
marmarek
requested changes
Sep 27, 2024
alimirjamali
force-pushed
the
DNF5-qvm-template
branch
from
b3c203d to
83a68fa
Compare
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Sep 27, 2024
marmarek
reviewed
Sep 27, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Sep 27, 2024
marmarek
approved these changes
Sep 28, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Oct 10, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Oct 10, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Oct 11, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Oct 11, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Oct 14, 2024
alimirjamali
added a commit
to alimirjamali/qubes-core-agent-linux
that referenced
this pull request
Oct 14, 2024
marmarek
pushed a commit
to QubesOS/qubes-core-agent-linux
that referenced
this pull request
Nov 5, 2024
related: QubesOS/qubes-core-admin-client#308 (cherry picked from commit e0cecd0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: QubesOS/qubes-issues#9244