Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxl: add ACPI SLIC table support #15

Merged
merged 1 commit into from
Oct 24, 2019
Merged

libxl: add ACPI SLIC table support #15

merged 1 commit into from
Oct 24, 2019

Conversation

jevank
Copy link
Contributor

@jevank jevank commented Aug 28, 2019

Libxl driver did not support setup additional acpi firmware to xen guest. It is necessary to activate OEM Windows installs. This patch allow to define in OS section acpi table param (which supported domain common schema).

@jevank
Copy link
Contributor Author

jevank commented Aug 28, 2019

@marmarek
Copy link
Member

Please add Signed-off-by line (see https://developercertificate.org/). This way I'll be able to send it upstream.

@marmarek
Copy link
Member

If that force-push was about that, I don't see any change.

@jevank
Copy link
Contributor Author

jevank commented Aug 29, 2019

Hm, I see Signed-off-by in commit message. git commit -s made it. Or it need to be in patch body?

@marmarek
Copy link
Member

I meant the patch body.

@jevank
Copy link
Contributor Author

jevank commented Aug 29, 2019

Now should be ok.

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you've probably seen, the patch is included in upstream repository. So, lets include it in this version too.

@marmarek marmarek merged commit 7748089 into QubesOS:release4.0 Oct 24, 2019
@jevank
Copy link
Contributor Author

jevank commented Oct 24, 2019

@marmarek Thank you for pushing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants