Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4.2] KDE should use new qubes menu #8159

Closed
Augsch123 opened this issue Apr 29, 2023 · 6 comments · Fixed by QubesOS/qubes-desktop-linux-kde#16
Closed

[R4.2] KDE should use new qubes menu #8159

Augsch123 opened this issue Apr 29, 2023 · 6 comments · Fixed by QubesOS/qubes-desktop-linux-kde#16
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: desktop-linux-kde Support for the K Desktop Environment (KDE) diagnosed Technical diagnosis has been performed (see issue comments). P: blocker Priority: blocker. Prevents release or would have prevented release if known prior to release. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.2

Comments

@Augsch123
Copy link

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

The KDE Application launcher will crash if I install KDE plasma latest ( 5.27 atm ) and kde-settings-qubes 5.12.

Steps to reproduce

  1. Install KDE by running
sudo qubes-dom0-update apper breeze-icon-theme colord-kde dolphin kcm_systemd kde-runtime kde-settings-pulseaudio kde-style-breeze kdelibs kdeplasma-addons kdialog khelpcenter khotkeys kinfocenter kmenuedit kmix konsole5 kscreen ksysguard kwin phonon-qt5-backend-gstreamer plasma-breeze plasma-desktop plasma-desktop-doc plasma-pa plasma-user-manager plasma-workspace polkit-kde qt5-qdbusviewer sddm sddm-breeze sddm-kcm sni-qt
  1. Logout and log back in, and find that the launcher is working well.
  2. Install kde-settings-qubes.
  3. Logout and log back in, and the launcher crashes.
  4. Remove kde-settings-qubes.
  5. Logout and log back in, and the launcher crashes.
  6. Fully reinstall KDE by running
sudo qubes-dom0-update --action=reinstall apper breeze-icon-theme colord-kde dolphin kcm_systemd kde-runtime kde-settings-pulseaudio kde-style-breeze kdelibs kdeplasma-addons kdialog khelpcenter khotkeys kinfocenter kmenuedit kmix konsole5 kscreen ksysguard kwin phonon-qt5-backend-gstreamer plasma-breeze plasma-desktop plasma-desktop-doc plasma-pa plasma-user-manager plasma-workspace polkit-kde qt5-qdbusviewer sddm sddm-breeze sddm-kcm sni-qt
  1. Logout and log back in, and find that the launcher is working well.

I repeated step 3 to 8 two times, and this issue is reproducible.

Expected behavior

The launcher shouldn't crash.

Actual behavior

It crashed with following messages:

Sorry! there was an error loading Application launcher.

file:///usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/Kickoff.qml:157:34: Type FullRepresentation unavailable

file:///usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/FullRepresentation.qml:43:5: KickoffButton is not a type
@Augsch123 Augsch123 added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Apr 29, 2023
@andrewdavidwong andrewdavidwong added C: desktop-linux-kde Support for the K Desktop Environment (KDE) needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Apr 29, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Apr 29, 2023
@marmarek marmarek mentioned this issue May 4, 2023
Closed
@marmarek marmarek mentioned this issue May 22, 2023
Closed
@marmarek
Copy link
Member

As noted in the duplicate issue: the fix here is not to make the old menu customization work (it was quite invasive), but adjust the startup setup to replace KDE native menu with the new qubes menu.

@marmarek marmarek added P: blocker Priority: blocker. Prevents release or would have prevented release if known prior to release. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Jun 24, 2023
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jun 24, 2023
@marmarek marmarek mentioned this issue Jul 6, 2023
Open
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 7, 2023
@marmarek
Restore original menu layout file
f16bc10 
Since using new qubes menu, replacing kickoff's layout is not necessary
anymore. The layout file included here did not work with R4.2's KDE
version (5.27).

Fixes QubesOS/qubes-issues#8159
@marmarek marmarek mentioned this issue Jul 7, 2023
Merged
@marmarek marmarek changed the title [R4.2] KDE launcher crash after kde-settings-qubes installed [R4.2] KDE should use new qubes menu Jul 12, 2023
@qubesos-bot qubesos-bot mentioned this issue Jul 12, 2023
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-kde (including package desktop-linux-kde) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-kde has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-kde (including package desktop-linux-kde) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Jul 13, 2023
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 14, 2023
@marmarek
Move menu launcher to the left on the update too
10af4a8 
Apparently there is no other API method than settings AppletOrder
directly. This may require restarting panel after applying the change -
it seems like changing it on the live panel doesn't work.

QubesOS/qubes-issues#8159
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 14, 2023
@marmarek
Rename 10-qubes.js to 11-qubes.js to make it applied on update
1042a82 
KDE stores list of updates already applied, by name. Since 10-qubes.js
was changed, rename it so the new version is applied too.

QubesOS/qubes-issues#8159
@marmarek marmarek mentioned this issue Jul 14, 2023
Merged
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 16, 2023
@marmarek
Move menu launcher to the left on the update too
91555dc 
Apparently there is no other API method than settings AppletOrder
directly. This may require restarting panel after applying the change -
it seems like changing it on the live panel doesn't work.

QubesOS/qubes-issues#8159
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 16, 2023
@marmarek
Rename 10-qubes.js to 11-qubes.js to make it applied on update
b0bdd0e 
KDE stores list of updates already applied, by name. Since 10-qubes.js
was changed, rename it so the new version is applied too.

QubesOS/qubes-issues#8159
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 16, 2023
@marmarek
Move menu launcher to the left on the update too
d7555a7 
Apparently there is no other API method than settings AppletOrder
directly. This may require restarting panel after applying the change -
it seems like changing it on the live panel doesn't work.

Furthermore, on initial start the AppletOrder may be not set yet, in
that case get initial value from widgetIds property.

QubesOS/qubes-issues#8159
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Jul 16, 2023
@marmarek
Rename 10-qubes.js to 11-qubes.js to make it applied on update
6d5d8d7 
KDE stores list of updates already applied, by name. Since 10-qubes.js
was changed, rename it so the new version is applied too.

QubesOS/qubes-issues#8159
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Aug 2, 2023
@marmarek
Add new menu launcher to the initial panel layout too
537aea8 
The layout update script is running too early on the first KDE startup,
and default widgets are not there yet. This ends up in menu launcher
remaining on the right, instead of the left.

QubesOS/qubes-issues#8159
marmarek added a commit to marmarek/qubes-desktop-linux-kde that referenced this issue Aug 3, 2023
@marmarek
Add new menu launcher to the initial panel layout too
6426f46 
The layout update script is running too early on the first KDE startup,
and default widgets are not there yet. This ends up in menu launcher
remaining on the right, instead of the left.

QubesOS/qubes-issues#8159
@qubesos-bot qubesos-bot mentioned this issue Aug 5, 2023
Closed
@andrewdavidwong andrewdavidwong added the affects-4.2 This issue affects Qubes OS 4.2. label Aug 8, 2023
@tasket tasket mentioned this issue Aug 8, 2023
Open
@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-kde has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-kde (including package desktop-linux-kde) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Oct 18, 2023
Closed
@qubesos-bot qubesos-bot mentioned this issue Feb 5, 2024
Closed
@qubesos-bot qubesos-bot mentioned this issue Apr 18, 2024
Closed
@qubesos-bot qubesos-bot mentioned this issue Aug 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: desktop-linux-kde Support for the K Desktop Environment (KDE) diagnosed Technical diagnosis has been performed (see issue comments). P: blocker Priority: blocker. Prevents release or would have prevented release if known prior to release. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.2
Development

Successfully merging a pull request may close this issue.

Update config script for newer KDE and Qubes Menu marmarek/qubes-desktop-linux-kde
4 participants
@marmarek @andrewdavidwong @qubesos-bot @Augsch123