feat: nationality support #991
Conversation
| #include <QMap> | ||
| #include <QString> | ||
|
|
||
| QMap<QString, QString> isoAlpha2ToIoc = { |
There was a problem hiding this comment.
I don't know, fixed list of codes in the source. How will we deal with it if there is any correction or modification of the codes?
Country names evolve over time.
There was a problem hiding this comment.
I suppose we dont use any packaging system in this c++ project that would handle this. Git submodule for such a small thing would be overkill. The countries participating in orienteering are hardly going to change to have a meaningful impact, but I am open to suggesting how to handle this better.
|
@otahirs, do I need to go through the code for the races from Eventor? |
|
@otahirs, how did you write it to the database? I don't see any change in the db definition (DbSchema.qml). But from the code it seems to me that you added some columns. |
|
should I be targeting |
|
@otahirs, you need to increase the DB version in : |
I'm still creating new features for both |
this adds basic support for Nationality (country code)
the motivation is to have national flags shown on oresults.eu, as quickevent lacks those in the exports in comparison to meos or kramer
Geting nationality data
normal events
normal events gets nationality info from ORIS as the endpoint
https://oris.orientacnisporty.cz/API/?format=json&method=getEventEntries&eventid=%1contains Nationality data, even thought they need to be converted into IOC format https://github.com/international-orienteering-federation/datastandard-v3/blob/24eb108e4c6b5e2904e5f8f0e49142e45e2c5230/IOF.xsd#L4224relay
relay endpoint for syncing entries does not have nationality data, so no automatic support there yet for importing it
Export / Import
implemented for normal/relay iof xml import and exports
xmlimporter also touched