Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftLint] Remove identifier_name from disabled_rules #563

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Jul 6, 2018

Ref: #370

@ikesyo ikesyo requested a review from a team July 6, 2018 00:39
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. I'm guessing there's no swiftlint option to allow starting a variable name with an underscore?

@ikesyo
Copy link
Member Author

ikesyo commented Jul 8, 2018

Disabling validates_start_with_lowercase option will be an option (but will not be preferable).

@ikesyo
Copy link
Member Author

ikesyo commented Jul 9, 2018

I'll merge this as is for now. Thanks for the review @sharplet!

@ikesyo ikesyo merged commit 471f58e into master Jul 9, 2018
@ikesyo ikesyo deleted the swiftlint-identifier_name branch July 9, 2018 00:15
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
[SwiftLint] Remove identifier_name from disabled_rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants