Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftLint] Remove force_try from disabled_rules #582

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Jul 23, 2018

Ref: #370

@ikesyo ikesyo requested a review from a team July 23, 2018 17:07
file: FileString = #file,
line: UInt = #line,
closure: () throws -> Void)
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

@ikesyo ikesyo force-pushed the swiftlint-force_try branch 2 times, most recently from 9abb08e to 3a5e608 Compare July 23, 2018 17:16
@ikesyo ikesyo force-pushed the swiftlint-force_try branch from 3a5e608 to c5b7a71 Compare July 23, 2018 17:17
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for re-enabling the force_try rule. Suppressing the rule for a few cases is much better as it will prevent new ones from creeping into the code.

@phatblat phatblat merged commit e04ac7a into master Jul 23, 2018
@phatblat phatblat deleted the swiftlint-force_try branch July 23, 2018 20:47
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
[SwiftLint] Remove force_try from disabled_rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants