Add Loom support for quilt.mod.json5
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
those switch rules aaaaaaaaaaaaa
TheGlitch76
reviewed
Jul 4, 2023
EnnuiL
commented
Jul 4, 2023
|
I have done further work on the other areas in order to prevent misuse of QMJ5s; While I feel like the work's complete, I am not completely sure what else needs to be done for Quilt Loom; |
EnnuiL
changed the title
quilt.mod.json5quilt.mod.json5
|
I'm merging this in with Loom 1.3. |
|
I hope to make the QMJ5 support as seamless and non-problematic as possible |
Juuxel
added a commit
to Juuxel/fabric-loom
that referenced
this pull request
Jul 19, 2023
See: - RFC: QuiltMC/rfcs#83 - Build tool impl: QuiltMC/quilt-loom#36, QuiltMC/quilt-loom#37 - Required loader PR: QuiltMC/quilt-loader#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires quilt-loader#329, some further testing, and
a RFC update;there isn't any easy way to update the specification in order to mention "oh, QMJ5 is fine if internal-only"there, rfcs#83;But other than that? Everything is going great!