Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstallerVersion.astro triggers on unrelated pages #216

Closed
TheEpicBlock opened this issue May 3, 2024 · 0 comments · Fixed by #217
Closed

InstallerVersion.astro triggers on unrelated pages #216

TheEpicBlock opened this issue May 3, 2024 · 0 comments · Fixed by #217

Comments

@TheEpicBlock
Copy link
Contributor

The InstallerVersion.astro queries the quilt maven. But it seems to be run on the mc-patchnotes page. This is also evident in the code where it null-checks the element with id installer-version. I believe an easy fix would be to simply move that check to be earlier. So the http call isn't made when not needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scripts running when they should not Pyrofab/quiltmc.org
1 participant
@TheEpicBlock