Fix scripts running when they should not #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpcraftLP
approved these changes
May 4, 2024
TheEpicBlock
approved these changes
May 4, 2024
ix0rai
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Swagger UI I used a dynamic import so the script gets split into its own chunk, and only gets loaded on the relevant page.
For the installer version, the imported module is really small so a dynamic import was not needed. As for the "condition", I noticed the Astro doc was suggesting web components to implement custom behaviour, and I figured it would do a decent job at structuring the code, so I used this instead of a basic
getElementById.fixes #215
fixes #216
See preview on Cloudflare Pages: https://preview-217.quiltmc-org.pages.dev